[vlc-commits] commit: skins2: fix race condition (if multiple vouts) (Erwan Tulou )

[git at videolan.org]

vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Mon Dec  6 20:54:59 2010 +0100| [740ab95dd85658ed11e32f40f5363632e92e5a58] | committer: Erwan Tulou 

skins2: fix race condition (if multiple vouts)

Close must also be serialized (one single global lock/wait).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=740ab95dd85658ed11e32f40f5363632e92e5a58
---

 modules/gui/skins2/src/skin_main.cpp |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/modules/gui/skins2/src/skin_main.cpp b/modules/gui/skins2/src/skin_main.cpp
index c60b9e8..1fa1289 100644
--- a/modules/gui/skins2/src/skin_main.cpp
+++ b/modules/gui/skins2/src/skin_main.cpp
@@ -362,7 +362,9 @@ static void WindowClose( vlc_object_t *p_this )
     vout_window_t *pWnd = (vout_window_t *)p_this;
     intf_thread_t *pIntf = (intf_thread_t *)pWnd->sys;
 
+    vlc_mutex_lock( &serializer );
     VoutManager::releaseWindow( pIntf, pWnd );
+    vlc_mutex_unlock( &serializer );
 
     vlc_object_release( pIntf );
 }