[vlc-commits] commit: skins2: implement a new 'focus' attribute for text control ( Erwan Tulou )

[git at videolan.org]

vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Sat Dec 11 11:56:14 2010 +0100| [81717b48cdb23df13c3ca31bd2c5b881ec39e8f4] | committer: Erwan Tulou 

skins2: implement a new 'focus' attribute for text control

Up to now, text control could but be focusable, and this focus was used
to scroll text, should it be too long for full display.

>From a user viewpoint, this behavior is often counterintuitive :
 - Most of the time, the control is designed to fit the text anyway, and
   scrolling is not expected.
 - On the other hand, an underlying control may be used to move the window
   (for instance, the title bar), and a text control is expected not to
   interact in this endeavor. Same goes for popupmenu, that is expected
   to work if one happens to right-click on a text control.

This patch adds a 'focus' attribute to the text control, and leave it to the
skins developper to decide which behavior is most desirable on a per-control
basis. focus still defaults to true to maintain skins current behavior.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=81717b48cdb23df13c3ca31bd2c5b881ec39e8f4
---

 doc/skins/skins2-howto.xml                 |    5 +++++
 modules/gui/skins2/controls/ctrl_text.cpp  |    9 ++++++---
 modules/gui/skins2/controls/ctrl_text.hpp  |    6 ++++--
 modules/gui/skins2/parser/builder.cpp      |    5 +++--
 modules/gui/skins2/parser/builder_data.def |    2 +-
 modules/gui/skins2/parser/builder_data.hpp |    5 +++--
 modules/gui/skins2/parser/skin_parser.cpp  |    4 +++-
 share/skins2/skin.dtd                      |    1 +
 8 files changed, 26 insertions(+), 11 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=81717b48cdb23df13c3ca31bd2c5b881ec39e8f4