[vlc-commits] commit: playlist_pls: fix use after free ( can be triggered by some invalid shoutcast playlist files). ( Rémi Duraffort )

[git at videolan.org]

vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Thu Jun 17 21:20:25 2010 +0200| [e1ff44d2afe03c87242cd3e5e9b48146bdb1e1da] | committer: Rémi Duraffort 

playlist_pls: fix use after free (can be triggered by some invalid shoutcast playlist files).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e1ff44d2afe03c87242cd3e5e9b48146bdb1e1da
---

 modules/demux/playlist/pls.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/modules/demux/playlist/pls.c b/modules/demux/playlist/pls.c
index ac5d99a..20a6f52 100644
--- a/modules/demux/playlist/pls.c
+++ b/modules/demux/playlist/pls.c
@@ -147,7 +147,7 @@ static int Demux( demux_t *p_demux )
                 input_item_node_AppendItem( p_subitems, p_input );
                 vlc_gc_decref( p_input );
                 free( psz_mrl_orig );
-                psz_mrl_orig = NULL;
+                psz_mrl_orig = psz_mrl = NULL;
             }
             else
             {
@@ -204,7 +204,6 @@ static int Demux( demux_t *p_demux )
         input_item_node_AppendItem( p_subitems, p_input );
         vlc_gc_decref( p_input );
         free( psz_mrl_orig );
-        psz_mrl = NULL;
     }
     else
     {