[vlc-commits] commit: Revert "modules: Put bool at the end of the structure to eventually ease packing." ( Pierre d'Herbemont )

git version control git at videolan.org
Fri Mar 5 14:59:09 CET 2010


vlc | branch: master | Pierre d'Herbemont <pdherbemont at free.fr> | Fri Mar  5 14:58:20 2010 +0100| [f296eec57a1c1614fd83bb5bff115b4aac9c8c4b] | committer: Pierre d'Herbemont 

Revert "modules: Put bool at the end of the structure to eventually ease packing."

This reverts commit 58275b9dd582d873d42c08a47873ae44b67f1003.

This is probably too late for this kind of changes. And it's probably not the best way to reduce the hudge memory footprint of the module bank.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f296eec57a1c1614fd83bb5bff115b4aac9c8c4b
---

 src/modules/modules.h |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/modules/modules.h b/src/modules/modules.h
index 1584850..2973c43 100644
--- a/src/modules/modules.h
+++ b/src/modules/modules.h
@@ -112,6 +112,9 @@ struct module_t
     char    *psz_capability;                                 /**< Capability */
     int      i_score;                          /**< Score for the capability */
 
+    bool b_unloadable;                        /**< Can we be dlclosed? */
+    bool b_submodule;                        /**< Is this a submodule? */
+
     /* Callbacks */
     int  ( * pf_activate )   ( vlc_object_t * );
     void ( * pf_deactivate ) ( vlc_object_t * );
@@ -134,12 +137,6 @@ struct module_t
 
     bool          b_builtin;  /* Set to true if the module is built in */
     bool          b_loaded;        /* Set to true if the dll is loaded */
-
-    /*
-     * Other variables set by the module to identify itself
-     */
-    bool b_unloadable;                        /**< Can we be dlclosed? */
-    bool b_submodule;                        /**< Is this a submodule? */
 };
 
 module_t *vlc_module_create (vlc_object_t *);



More information about the vlc-commits mailing list