[vlc-commits] commit: Qt: don't emit redundant InputManager::statusChanged() signals ( Jakob Leben )

git at videolan.org git at videolan.org
Mon Mar 8 11:14:08 CET 2010


vlc | branch: master | Jakob Leben <jleben at videolan.org> | Mon Mar  8 10:47:49 2010 +0100| [3968fd2daf7f24dbd4e654268ffa1c8fd3d75b80] | committer: Jakob Leben 

Qt: don't emit redundant InputManager::statusChanged() signals

Thanks to Srikanth Raju <srikiraju at gmail.com> for pointing out the problem.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3968fd2daf7f24dbd4e654268ffa1c8fd3d75b80
---

 modules/gui/qt4/input_manager.cpp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/gui/qt4/input_manager.cpp b/modules/gui/qt4/input_manager.cpp
index c7222c2..b5058e1 100644
--- a/modules/gui/qt4/input_manager.cpp
+++ b/modules/gui/qt4/input_manager.cpp
@@ -103,13 +103,14 @@ void InputManager::setInput( input_thread_t *_p_input )
     {
         msg_Dbg( p_intf, "IM: Setting an input" );
         vlc_object_hold( p_input );
-        emit statusChanged( PLAYING_S );
+        addCallbacks();
+        UpdateStatus();
         UpdateName();
         UpdateArt();
         UpdateTeletext();
         UpdateNavigation();
         UpdateVout();
-        addCallbacks();
+
         p_item = input_GetItem( p_input );
         emit rateChanged( var_GetFloat( p_input, "rate" ) );
     }
@@ -695,7 +696,6 @@ void InputManager::togglePlayPause()
         int state = var_GetInteger( p_input, "state" );
         state = ( state != PLAYING_S ) ? PLAYING_S : PAUSE_S;
         var_SetInteger( p_input, "state", state );
-        emit statusChanged( state );
     }
 }
 



More information about the vlc-commits mailing list