[vlc-commits] commit: growl: fix pontential use after free ( var_delcallbacl called to late). ( Rémi Duraffort )

[git at videolan.org]

vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Sun Mar 28 17:18:39 2010 +0200| [0c33ffc1b394a41b099dbc7e949ba705d8d44e54] | committer: Rémi Duraffort 

growl: fix pontential use after free (var_delcallbacl called to late).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0c33ffc1b394a41b099dbc7e949ba705d8d44e54
---

 modules/misc/notify/growl.m |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/misc/notify/growl.m b/modules/misc/notify/growl.m
index 52ad6f9..71ecdd1 100644
--- a/modules/misc/notify/growl.m
+++ b/modules/misc/notify/growl.m
@@ -134,13 +134,13 @@ static void Close( vlc_object_t *p_this )
 {
     intf_sys_t *p_sys = ((intf_thread_t*)p_this)->p_sys;
 
+    var_DelCallback( pl_Get( p_this ), "item-current", ItemChange, p_this );
+
     CFRelease( p_sys->default_icon );
     CFRelease( p_sys->app_name );
     CFRelease( p_sys->notification_type );
     [p_sys->p_pool release];
     free( p_sys );
-
-    var_DelCallback( pl_Get( p_this ), "item-current", ItemChange, p_this );
 }
 
 /*****************************************************************************