[vlc-commits] commit: pulse: require Xlib ( Rémi Denis-Courmont )

[git at videolan.org]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue May 25 20:28:18 2010 +0300| [36c1cbc3f2e228ef120e7413cc2613d3f8aded5c] | committer: Rémi Denis-Courmont 

pulse: require Xlib

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=36c1cbc3f2e228ef120e7413cc2613d3f8aded5c
---

 configure.ac                 |   16 +++++++++-------
 modules/audio_output/pulse.c |    4 +++-
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/configure.ac b/configure.ac
index 0136744..5e64648 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3644,14 +3644,16 @@ fi
 dnl
 dnl  Pulseaudio module
 dnl
-PKG_ENABLE_MODULES_VLC([PULSE], [], [libpulse >= 0.9.11], [Pulseaudio support], [auto])
-AS_IF([ test "$have_x" = yes],[
-       VLC_ADD_LIBS([pulse], [${X_LIBS} ${X_PRE_LIBS} -lX11])
-     ],[
-        AC_MSG_WARN([The pulse audio output module will be built without X 
-		     support. If you use VLC under X, you will experience 
-		     strange threading problems])
+AS_IF([test "${no_x}" = "yes"], [
+  AS_IF([test "${enable_pulse}" = "yes"], [
+    AC_MSG_ERROR([Xlib is required for VLC PulseAudio support
+(see http://www.pulseaudio.org/ticket/799 for further reference).])
+  ])
+], [
+  PKG_ENABLE_MODULES_VLC([PULSE], [], [libpulse >= 0.9.11], [Pulseaudio support], [auto])
+  VLC_ADD_LIBS([pulse], [${X_LIBS} ${X_PRE_LIBS} -lX11])
 ])
+
 dnl
 dnl  Portaudio module
 dnl
diff --git a/modules/audio_output/pulse.c b/modules/audio_output/pulse.c
index 852e418..f36ec09 100644
--- a/modules/audio_output/pulse.c
+++ b/modules/audio_output/pulse.c
@@ -121,7 +121,9 @@ static int Open ( vlc_object_t *p_this )
     struct pa_buffer_attr a;
     struct pa_channel_map map;
 
-#ifdef HAVE_X11_XLIB_H
+#ifdef X_DISPLAY_MISSING
+# error Xlib required due to PulseAudio bug 799!
+#else
     if( !XInitThreads() )
         return VLC_EGENERIC;
 #endif