[vlc-commits] commit: x264: default b-pyramid to "normal" from X264_BUILD >= 87 ( Ilkka Ollakka )

[git at videolan.org]

vlc/vlc-1.1 | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Wed May 26 00:16:15 2010 +0300| [0f752ff46c1631fea1e9a3c9951081758ee8bd36] | committer: Jean-Baptiste Kempf 

x264: default b-pyramid to "normal" from X264_BUILD >= 87

libx264 changed default to normal in that build too, also change logic
littebit so b-pyramid selection works better.

> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=0f752ff46c1631fea1e9a3c9951081758ee8bd36
---

 modules/codec/x264.c |   25 ++++++++++++++++---------
 1 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/modules/codec/x264.c b/modules/codec/x264.c
index 39d17d3..58398ab 100644
--- a/modules/codec/x264.c
+++ b/modules/codec/x264.c
@@ -445,7 +445,11 @@ vlc_module_begin ()
                  B_BIAS_LONGTEXT, false )
         change_integer_range( -100, 100 )
 
-#if X264_BUILD >= 78
+#if X264_BUILD >= 87
+    add_string( SOUT_CFG_PREFIX "bpyramid", "normal", NULL, BPYRAMID_TEXT,
+              BPYRAMID_LONGTEXT, false )
+        change_string_list( bpyramid_list, bpyramid_list, 0 );
+#elif X264_BUILD >= 78
     add_string( SOUT_CFG_PREFIX "bpyramid", "none", NULL, BPYRAMID_TEXT,
               BPYRAMID_LONGTEXT, false )
         change_string_list( bpyramid_list, bpyramid_list, 0 );
@@ -930,16 +934,19 @@ static int  Open ( vlc_object_t *p_this )
 
 #if X264_BUILD >= 78
     psz_val = var_GetString( p_enc, SOUT_CFG_PREFIX "bpyramid" );
-    if( strcmp( psz_val, "none" ) )
+    if( !strcmp( psz_val, "normal" ) )
     {
-       if ( !strcmp( psz_val, "strict" ) )
-       {
-          p_sys->param.i_bframe_pyramid = X264_B_PYRAMID_STRICT;
-       } else if ( !strcmp( psz_val, "normal" ) )
-       {
-          p_sys->param.i_bframe_pyramid = X264_B_PYRAMID_NORMAL;
-       }
+        p_sys->param.i_bframe_pyramid = X264_B_PYRAMID_NORMAL;
     }
+    else if ( !strcmp( psz_val, "strict" ) )
+    {
+        p_sys->param.i_bframe_pyramid = X264_B_PYRAMID_STRICT;
+    }
+    else if ( !strcmp( psz_val, "none" ) )
+    {
+        p_sys->param.i_bframe_pyramid = X264_B_PYRAMID_NONE;
+    }
+
     free( psz_val );
 #else
     p_sys->param.b_bframe_pyramid = var_GetBool( p_enc, SOUT_CFG_PREFIX "bpyramid" );