[vlc-commits] commit: Fixed a double free on error (http interface). (Laurent Aimar )

[git at videolan.org]

vlc/vlc-1.1 | branch: master | Laurent Aimar <fenrir at videolan.org> | Sun Oct 31 13:31:50 2010 +0100| [69cb599b288c46759e65209f734a484c88203dd1] | committer: Rémi Duraffort 

Fixed a double free on error (http interface).
(cherry picked from commit 14f8dbd47bd07de8b336d0d4c1747757a14d0737)

Signed-off-by: Rémi Duraffort <ivoire at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=69cb599b288c46759e65209f734a484c88203dd1
---

 modules/control/http/http.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/modules/control/http/http.c b/modules/control/http/http.c
index bd3062c..c8469e8 100644
--- a/modules/control/http/http.c
+++ b/modules/control/http/http.c
@@ -259,8 +259,6 @@ static int Open( vlc_object_t *p_this )
         goto failed;
     }
 
-    free( psz_src );
-
     if( var_InheritBool( p_intf, "http-album-art" ) )
     {
         /* FIXME: we're leaking h */
@@ -277,6 +275,7 @@ static int Open( vlc_object_t *p_this )
         p_sys->p_art_handler = h->p_handler;
     }
 
+    free( psz_src );
     return VLC_SUCCESS;
 
 failed: