[vlc-commits] commit: smb: Fix stack smashing ( Rafaël Carré )

[git at videolan.org]

vlc/vlc-1.1 | branch: master | Rafaël Carré <rafael.carre at gmail.com> | Tue Nov  2 14:56:09 2010 +0100| [b531955c2206c88250cacc511793facc32cbced6] | committer: Rafaël Carré 

smb: Fix stack smashing

It is described on http://shinnai.altervista.org/exploits/SH-008-20101026.html
Thanks to geal for helping finding the problem

> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=b531955c2206c88250cacc511793facc32cbced6
---

 modules/access/smb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/access/smb.c b/modules/access/smb.c
index d2648a4..2cc616f 100644
--- a/modules/access/smb.c
+++ b/modules/access/smb.c
@@ -362,7 +362,7 @@ static void Win32AddConnection( access_t *p_access, char *psz_path,
                                 char *psz_user, char *psz_pwd,
                                 char *psz_domain )
 {
-    DWORD (*OurWNetAddConnection2)( LPNETRESOURCE, LPCTSTR, LPCTSTR, DWORD );
+    DWORD WINAPI (*OurWNetAddConnection2)( LPNETRESOURCE, LPCTSTR, LPCTSTR, DWORD );
     char psz_remote[MAX_PATH], psz_server[MAX_PATH], psz_share[MAX_PATH];
     NETRESOURCE net_resource;
     DWORD i_result;