[vlc-commits] commit: skins2: fix wrong check (cosmetics) (Erwan Tulou )

git at videolan.org git at videolan.org
Wed Nov 17 10:54:29 CET 2010


vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Wed Nov 17 10:31:00 2010 +0100| [a7f80fa2a49eec99c0e8d6410a13501e970a0650] | committer: Erwan Tulou 

skins2: fix wrong check (cosmetics)

For clarity, i_children can be -1 (at init) or 0 for no child. Yet, there was
no bug, since buildNode was just a noop for -1.

pointed out on the forum

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a7f80fa2a49eec99c0e8d6410a13501e970a0650
---

 modules/gui/skins2/vars/playtree.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/gui/skins2/vars/playtree.cpp b/modules/gui/skins2/vars/playtree.cpp
index c8dfb91..17ef793 100644
--- a/modules/gui/skins2/vars/playtree.cpp
+++ b/modules/gui/skins2/vars/playtree.cpp
@@ -248,7 +248,7 @@ void Playtree::buildNode( playlist_item_t *pNode, VarTree &rTree )
                      playlist_CurrentPlayingItem(m_pPlaylist) == pNode->pp_children[i],
                      false, pNode->pp_children[i]->i_flags & PLAYLIST_RO_FLAG,
                      pNode->pp_children[i] );
-        if( pNode->pp_children[i]->i_children )
+        if( pNode->pp_children[i]->i_children > 0 )
         {
             buildNode( pNode->pp_children[i], rTree.back() );
         }



More information about the vlc-commits mailing list