[vlc-commits] commit: Win32: cancel_data is on the stack, don't free it ( =?UTF-8?Q?R=C3=A9mi=20Denis=2DCourmont=20?=)

[git at videolan.org]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov 23 23:27:44 2010 +0200| [4e842f86995640371cc915c093003a47c3076b55] | committer: Rémi Denis-Courmont 

Win32: cancel_data is on the stack, don't free it

In practice, this bug was hidden by another bug in the thread variables
implementation: the destruction callback is never invoked.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4e842f86995640371cc915c093003a47c3076b55
---

 src/win32/thread.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/win32/thread.c b/src/win32/thread.c
index 1d25b90..831c5be 100644
--- a/src/win32/thread.c
+++ b/src/win32/thread.c
@@ -153,7 +153,7 @@ BOOL WINAPI DllMain (HINSTANCE hinstDll, DWORD fdwReason, LPVOID lpvReserved)
         case DLL_PROCESS_ATTACH:
             vlc_mutex_init (&super_mutex);
             vlc_cond_init (&super_variable);
-            vlc_threadvar_create (&cancel_key, free);
+            vlc_threadvar_create (&cancel_key, NULL);
             break;
 
         case DLL_PROCESS_DETACH: