[vlc-commits] commit: macosx_dialog_provider: handle EXTENSION_WIDGET_CHECK_BOX and fixed a few warnings pointed by clang 's static analyser ( Felix Paul Kühne )

[git at videolan.org]

vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Thu Oct 21 21:59:05 2010 +0200| [d55ae1b896bfacbbd1738307d3e8824b3c7837e6] | committer: Felix Paul Kühne 

macosx_dialog_provider: handle EXTENSION_WIDGET_CHECK_BOX and fixed a few warnings pointed by clang's static analyser

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d55ae1b896bfacbbd1738307d3e8824b3c7837e6
---

 .../gui/macosx_dialog_provider/VLCProgressPanel.h  |    8 ++++----
 .../gui/macosx_dialog_provider/VLCProgressPanel.m  |    8 ++++----
 .../gui/macosx_dialog_provider/dialogProvider.m    |    1 +
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/modules/gui/macosx_dialog_provider/VLCProgressPanel.h b/modules/gui/macosx_dialog_provider/VLCProgressPanel.h
index 725f2ce..0c1dde4 100644
--- a/modules/gui/macosx_dialog_provider/VLCProgressPanel.h
+++ b/modules/gui/macosx_dialog_provider/VLCProgressPanel.h
@@ -35,10 +35,10 @@
 }
 - (void)createContentView;
 
-- setDialogTitle:(NSString *)title;
-- setDialogMessage:(NSString *)message;
-- setCancelButtonLabel:(NSString *)cancelLabel;
-- setProgressAsDouble:(double)value;
+- (void)setDialogTitle:(NSString *)title;
+- (void)setDialogMessage:(NSString *)message;
+- (void)setCancelButtonLabel:(NSString *)cancelLabel;
+- (void)setProgressAsDouble:(double)value;
 - (BOOL)isCancelled;
 
 - (IBAction)cancelDialog:(id)sender;
diff --git a/modules/gui/macosx_dialog_provider/VLCProgressPanel.m b/modules/gui/macosx_dialog_provider/VLCProgressPanel.m
index 89cbd34..d06dbc7 100644
--- a/modules/gui/macosx_dialog_provider/VLCProgressPanel.m
+++ b/modules/gui/macosx_dialog_provider/VLCProgressPanel.m
@@ -106,23 +106,23 @@
     [ourContentView addSubview:_iconView];
 }
 
-- setDialogTitle:(NSString *)title
+- (void)setDialogTitle:(NSString *)title
 {
     [_titleField setStringValue:title];
     [self setTitle:title];
 }
 
-- setDialogMessage:(NSString *)message
+- (void)setDialogMessage:(NSString *)message
 {
     [_messageField setStringValue:message];
 }
 
-- setCancelButtonLabel:(NSString *)cancelLabel
+- (void)setCancelButtonLabel:(NSString *)cancelLabel
 {
     [_cancelButton setTitle:cancelLabel];
 }
 
-- setProgressAsDouble:(double)value
+- (void)setProgressAsDouble:(double)value
 {
     [_progressBar setDoubleValue:value];
 }
diff --git a/modules/gui/macosx_dialog_provider/dialogProvider.m b/modules/gui/macosx_dialog_provider/dialogProvider.m
index 48aff36..e23ec6e 100644
--- a/modules/gui/macosx_dialog_provider/dialogProvider.m
+++ b/modules/gui/macosx_dialog_provider/dialogProvider.m
@@ -703,6 +703,7 @@ static void updateControlFromWidget(NSView *control, extension_widget_t *widget,
             [attrString release];
             break;
         }
+        case EXTENSION_WIDGET_CHECK_BOX:
         case EXTENSION_WIDGET_BUTTON:
         {
             assert([control isKindOfClass:[NSButton class]]);