[vlc-commits] commit: rtsp: fix socket leak (Pierre Ynard )

[git at videolan.org]

vlc/vlc-1.1 | branch: master | Pierre Ynard <linkfanel at yahoo.fr> | Sun Oct 24 10:17:13 2010 +0200| [8af0ef9a6928cc9088b1c57e7fe4dca6755067db] | committer: Pierre Ynard 

rtsp: fix socket leak

A socket is leaked when the client passes a wrong session identifier.
A remote attacker could craft malicious RTSP requests and...
(cherry picked from commit eea1cddcb651c874e66999a91962da3b3f85bed5)

Signed-off-by: Pierre Ynard <linkfanel at yahoo.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=8af0ef9a6928cc9088b1c57e7fe4dca6755067db
---

 modules/stream_out/rtsp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/modules/stream_out/rtsp.c b/modules/stream_out/rtsp.c
index a1cc953..4760478 100644
--- a/modules/stream_out/rtsp.c
+++ b/modules/stream_out/rtsp.c
@@ -596,6 +596,7 @@ static int RtspHandler( rtsp_stream_t *rtsp, rtsp_stream_id_t *id,
                         {
                             answer->i_status = 454;
                             vlc_mutex_unlock( &rtsp->lock );
+                            net_Close( track.fd );
                             continue;
                         }
                     }