[vlc-commits] macosx: don't show KeyConfigControl in the advanced prefs

Felix Paul Kühne git at videolan.org
Mon Apr 25 13:49:24 CEST 2011


vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Mon Apr 25 13:35:08 2011 +0200| [bfe08d36e52426600645cc175ad34e509346c58e] | committer: Felix Paul Kühne

macosx: don't show KeyConfigControl in the advanced prefs

The current implementation is broken by design and only confuses the users. Use SPrefs to change hotkeys and advanced prefs only for advanced stuff such as jump length changing, etc.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bfe08d36e52426600645cc175ad34e509346c58e
---

 modules/gui/macosx/prefs_widgets.m |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/modules/gui/macosx/prefs_widgets.m b/modules/gui/macosx/prefs_widgets.m
index 1cf55ec..085883b 100644
--- a/modules/gui/macosx/prefs_widgets.m
+++ b/modules/gui/macosx/prefs_widgets.m
@@ -858,11 +858,14 @@ o_textfield = [[[NSSecureTextField alloc] initWithFrame: s_rc] retain];       \
                         withView: o_parent_view];
         }
         break;
+    /* don't display keys in the advanced settings, since the current controls 
+    are broken by design. The user is required to change hotkeys in the sprefs
+    and can only change really advanced stuff here..
     case CONFIG_ITEM_KEY:
         p_control = [[KeyConfigControl alloc]
                         initWithItem: _p_item
                         withView: o_parent_view];
-        break;
+        break; */
     case CONFIG_ITEM_MODULE_LIST:
     case CONFIG_ITEM_MODULE_LIST_CAT:
         p_control = [[ModuleListConfigControl alloc]



More information about the vlc-commits mailing list