[vlc-commits] fix double free introduced by me in [7d84269bff]

Rafaël Carré git at videolan.org
Tue Aug 9 02:49:56 CEST 2011


vlc | branch: master | Rafaël Carré <rafael.carre at gmail.com> | Mon Aug  8 20:48:58 2011 -0400| [cc9602fe94ce68de0c985bde461974b01c644ee8] | committer: Rafaël Carré

fix double free introduced by me in [7d84269bff]

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=cc9602fe94ce68de0c985bde461974b01c644ee8
---

 src/playlist/tree.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/src/playlist/tree.c b/src/playlist/tree.c
index e306572..6234d87 100644
--- a/src/playlist/tree.c
+++ b/src/playlist/tree.c
@@ -157,11 +157,8 @@ int playlist_NodeDelete( playlist_t *p_playlist, playlist_item_t *p_root,
     int i;
     var_SetInteger( p_playlist, "playlist-item-deleted", p_root->i_id );
     ARRAY_BSEARCH( p_playlist->all_items, ->i_id, int, p_root->i_id, i );
-    if( i != -1 ) {
-        vlc_gc_decref(p_playlist->all_items.p_elems[i]->p_input);
-        printf("deleting %d %p\n", i, p_playlist->all_items.p_elems[i]->p_input);
+    if( i != -1 )
         ARRAY_REMOVE( p_playlist->all_items, i );
-    }
 
     if( p_root->i_children == -1 ) {
         ARRAY_BSEARCH( p_playlist->items,->i_id, int, p_root->i_id, i );



More information about the vlc-commits mailing list