[vlc-commits] skins2: remove a comment that proved wrong

Erwan Tulou git at videolan.org
Mon Jan 24 23:18:46 CET 2011


vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Mon Jan 24 19:10:57 2011 +0100| [5d2dcf67aee468907e34e243fa7b7e2ff201851b] | committer: Erwan Tulou

skins2: remove a comment that proved wrong

scrolling is coded twice in this file, because it contains two class
implementations (CtrlSliderCursor and CtrlSliderBg). Both need this code
since cursor can be on any one of these two controls when scrolling occurs.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5d2dcf67aee468907e34e243fa7b7e2ff201851b
---

 modules/gui/skins2/controls/ctrl_slider.cpp |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/modules/gui/skins2/controls/ctrl_slider.cpp b/modules/gui/skins2/controls/ctrl_slider.cpp
index 8eca2b0..377dff0 100644
--- a/modules/gui/skins2/controls/ctrl_slider.cpp
+++ b/modules/gui/skins2/controls/ctrl_slider.cpp
@@ -297,7 +297,6 @@ void CtrlSliderCursor::CmdMove::execute()
 
 void CtrlSliderCursor::CmdScroll::execute()
 {
-    // XXX Two of these in this file, figure out where it really belongs.
     int dir = static_cast<EvtScroll*>(m_pParent->m_pEvt)->getDirection();
     m_pParent->m_rVariable.set( scroll( EvtScroll::kUp == dir,
                                         m_pParent->m_rVariable.get() ) );
@@ -486,7 +485,6 @@ void CtrlSliderBg::handleEvent( EvtGeneric &rEvent )
     }
     else if( rEvent.getAsString().find( "scroll" ) != string::npos )
     {
-        // XXX Two of these in this file, figure out where it really belongs.
         int dir = static_cast<EvtScroll*>(&rEvent)->getDirection();
         m_rVariable.set( scroll( EvtScroll::kUp == dir, m_rVariable.get() ) );
     }



More information about the vlc-commits mailing list