[vlc-commits] RC (old): do not protect aout_VolumeUp() against overflow

Rémi Denis-Courmont git at videolan.org
Tue Jul 26 17:41:55 CEST 2011


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Jul 26 18:37:11 2011 +0300| [f073535f49e96be756d14ded36d76d1398c21744] | committer: Rémi Denis-Courmont

RC (old): do not protect aout_VolumeUp() against overflow

aout_VolumeUp() already handles this case correctly internally.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f073535f49e96be756d14ded36d76d1398c21744
---

 modules/control/rc.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/modules/control/rc.c b/modules/control/rc.c
index b88d08d..9d61e5e 100644
--- a/modules/control/rc.c
+++ b/modules/control/rc.c
@@ -1537,12 +1537,6 @@ static int VolumeMove( vlc_object_t *p_this, char const *psz_cmd,
         return VLC_EGENERIC;
     }
 
-    i_volume_step = config_GetInt( p_intf->p_libvlc, "volume-step" );
-    if ( i_nb_steps <= 0 || i_nb_steps > (AOUT_VOLUME_MAX/i_volume_step) )
-    {
-        i_nb_steps = 1;
-    }
-
     if( !strcmp(psz_cmd, "voldown") )
         i_nb_steps *= -1;
     if( aout_VolumeUp( p_intf->p_sys->p_playlist, i_nb_steps, &i_volume ) < 0 )



More information about the vlc-commits mailing list