[vlc-commits] skins2: fix some important playlist limitations or bugs

[Erwan Tulou]

vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Tue May 17 17:12:24 2011 +0200| [a9beb4078c7fce9efdebbcb11de762f1792fe6ea] | committer: Erwan Tulou

skins2: fix some important playlist limitations or bugs

This patch includes the following :
  - fix item misplacement (items were only appended instead of being inserted)
  - fix slider scrolling that could not adapt to the real size of the playlist
  - enhance drag&drop by allowing users to finely insert item being dropped
    into either the playlist or the media library.
  - optimise refresh (only rebuild playtree in case of visible item)
  - remove keeping a reference to a playlist_item_t* (since it is not
    refcounted, a lookup from the playlist with proper lock mechanism
    is needed)
  - remove the m_deleted flag (corner cases were never dealt with) and
    replace it with a notification prior to deletion
  - implement operator++ to simplify iterating visible items (cosmetics)

A deeper redesign/simplification and support for the new sql playlist would be a good thing though.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a9beb4078c7fce9efdebbcb11de762f1792fe6ea
---

 modules/gui/skins2/controls/ctrl_tree.cpp |  876 +++++++++++++----------------
 modules/gui/skins2/controls/ctrl_tree.hpp |   57 +-
 modules/gui/skins2/utils/var_percent.hpp  |   11 +-
 modules/gui/skins2/utils/var_tree.cpp     |  377 +++++++------
 modules/gui/skins2/utils/var_tree.hpp     |  178 +++++--
 modules/gui/skins2/vars/playtree.cpp      |  308 +++++++----
 modules/gui/skins2/vars/playtree.hpp      |   14 +
 7 files changed, 977 insertions(+), 844 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=a9beb4078c7fce9efdebbcb11de762f1792fe6ea