[vlc-commits] contribs: fix error handling while compressing tar archives

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Jun 29 15:01:46 2011 +0300| [4d540e48cc434b9d7e6b1dd912ca0dd4982f526f] | committer: Rémi Denis-Courmont

contribs: fix error handling while compressing tar archives

When the shell evaluates 'foo | bar', it returns the status of bar, not
foo. 'foo' can fail silently: so long as 'bar' succeeds, make will
not notice and will therefore not delete the target.

So lets use 'tar cv(z|j|J)' instead of 'tar cv | (gzip|bzip2|xz)'.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4d540e48cc434b9d7e6b1dd912ca0dd4982f526f
---

 contrib/src/ffmpeg/rules.mak |    2 +-
 contrib/src/tremor/rules.mak |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/src/ffmpeg/rules.mak b/contrib/src/ffmpeg/rules.mak
index 03c9267..1f2e317 100644
--- a/contrib/src/ffmpeg/rules.mak
+++ b/contrib/src/ffmpeg/rules.mak
@@ -122,7 +122,7 @@ ffmpeg-$(FFMPEG_VERSION).tar.gz:
 
 $(TARBALLS)/ffmpeg-svn.tar.gz:
 	$(SVN) export $(FFMPEG_SVN) ffmpeg-svn
-	tar cv ffmpeg-svn | gzip > $@
+	tar cvz ffmpeg-svn > $@
 
 FFMPEG_VERSION := svn
 
diff --git a/contrib/src/tremor/rules.mak b/contrib/src/tremor/rules.mak
index ccc4c25..f5104d4 100644
--- a/contrib/src/tremor/rules.mak
+++ b/contrib/src/tremor/rules.mak
@@ -7,7 +7,7 @@ endif
 $(TARBALLS)/tremor-svn.tar.xz:
 	rm -Rf tremor-svn
 	$(SVN) export http://svn.xiph.org/trunk/Tremor tremor-svn
-	tar cv tremor-svn | xz > $@
+	tar cvJ tremor-svn > $@
 
 .sum-tremor: tremor-svn.tar.xz
 	$(warning Integrity check skipped.)