[vlc-commits] Disable bandlimited resampler for the time being

Rémi Denis-Courmont git at videolan.org
Sat Mar 5 09:28:42 CET 2011


vlc/vlc-1.1 | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Mar  5 10:24:42 2011 +0200| [44e2291865a2582adbd34234ae1fdf94c082a352] | committer: Rémi Denis-Courmont

Disable bandlimited resampler for the time being

It is known to crash due to invalid buffer handling. On Linux, I get
memory accesses before the start of the audio buffer. It also crashes
on Windows. Until someone cares to fix it, and I think it really never
worked correctly, lets use the "ugly" resampler, which is not too ugly.

This should fix #3631, #4366, #4491 and possibly others.
(cherry picked from commit 9c74061333bd152a1467e49ed33b889c94410da9)

Conflicts:

	modules/audio_filter/Modules.am

> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=44e2291865a2582adbd34234ae1fdf94c082a352
---

 modules/audio_filter/resampler/Modules.am |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/audio_filter/resampler/Modules.am b/modules/audio_filter/resampler/Modules.am
index e759f99..8cb6b3b 100644
--- a/modules/audio_filter/resampler/Modules.am
+++ b/modules/audio_filter/resampler/Modules.am
@@ -2,6 +2,6 @@ SOURCES_ugly_resampler = ugly.c
 SOURCES_bandlimited_resampler = bandlimited.c bandlimited.h
 
 libvlc_LTLIBRARIES += \
-	libbandlimited_resampler_plugin.la \
-	libugly_resampler_plugin.la \
-	$(NULL)
+	libugly_resampler_plugin.la
+EXTRA_LTLIBRARIES += \
+	libbandlimited_resampler_plugin.la



More information about the vlc-commits mailing list