[vlc-commits] vlc_module_create(): remove useless parameter

Rémi Denis-Courmont git at videolan.org
Mon May 9 21:57:25 CEST 2011


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon May  9 22:35:04 2011 +0300| [18dc994608255e31f853e4d6d2e999a3327c7801] | committer: Rémi Denis-Courmont

vlc_module_create(): remove useless parameter

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=18dc994608255e31f853e4d6d2e999a3327c7801
---

 src/modules/cache.c   |    2 +-
 src/modules/entry.c   |    4 +---
 src/modules/modules.c |    4 ++--
 src/modules/modules.h |    2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/modules/cache.c b/src/modules/cache.c
index 241efc7..d24a5ab 100644
--- a/src/modules/cache.c
+++ b/src/modules/cache.c
@@ -239,7 +239,7 @@ void CacheLoad( vlc_object_t *p_this, module_bank_t *p_bank, const char *dir )
         LOAD_IMMEDIATE( pp_cache[i]->i_time );
         LOAD_IMMEDIATE( pp_cache[i]->i_size );
 
-        pp_cache[i]->p_module = vlc_module_create( p_this );
+        pp_cache[i]->p_module = vlc_module_create();
 
         /* Load additional infos */
         free( pp_cache[i]->p_module->psz_object_name );
diff --git a/src/modules/entry.c b/src/modules/entry.c
index 7660fd1..b6fb2d9 100644
--- a/src/modules/entry.c
+++ b/src/modules/entry.c
@@ -45,7 +45,7 @@ static void vlc_module_destruct (gc_object_t *obj)
 
 static const char default_name[] = "unnamed";
 
-module_t *vlc_module_create (vlc_object_t *obj)
+module_t *vlc_module_create (void)
 {
     module_t *module = malloc (sizeof (*module));
     if (module == NULL)
@@ -77,8 +77,6 @@ module_t *vlc_module_create (vlc_object_t *obj)
     module->domain = NULL;
     module->b_builtin = false;
     module->b_loaded = false;
-
-    (void)obj;
     return module;
 }
 
diff --git a/src/modules/modules.c b/src/modules/modules.c
index 6ddbb88..295462b 100644
--- a/src/modules/modules.c
+++ b/src/modules/modules.c
@@ -1030,7 +1030,7 @@ static module_t * AllocatePlugin( vlc_object_t * p_this, const char *psz_file )
 
     /* Now that we have successfully loaded the module, we can
      * allocate a structure for it */
-    p_module = vlc_module_create( p_this );
+    p_module = vlc_module_create();
     if( p_module == NULL )
     {
         module_Unload( handle );
@@ -1123,7 +1123,7 @@ static int AllocateBuiltinModule( vlc_object_t * p_this,
 
     /* Now that we have successfully loaded the module, we can
      * allocate a structure for it */
-    p_module = vlc_module_create( p_this );
+    p_module = vlc_module_create();
     if( p_module == NULL )
         return -1;
 
diff --git a/src/modules/modules.h b/src/modules/modules.h
index 6523d15..4347739 100644
--- a/src/modules/modules.h
+++ b/src/modules/modules.h
@@ -133,7 +133,7 @@ struct module_t
     char *              domain;                            /* gettext domain */
 };
 
-module_t *vlc_module_create (vlc_object_t *);
+module_t *vlc_module_create (void);
 module_t *vlc_submodule_create (module_t *module);
 
 void  module_InitBank( vlc_object_t * );



More information about the vlc-commits mailing list