[vlc-commits] Removed useless vlc_thread_set_priority() calls in macosx code.

[Laurent Aimar]

vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Mon May 23 17:57:31 2011 +0200| [36ce01dddb15185557fa796b8632d21037957baf] | committer: Laurent Aimar

Removed useless vlc_thread_set_priority() calls in macosx code.

The thread are already created with the right priority. If not, then
vlc_clone() should be fixed instead.
Also, the vlc_thread_set_priority() calls on the main interface thread
seem bogus, as the target thread is dedicated to monitor the libvlc
death and is not the main running thread.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=36ce01dddb15185557fa796b8632d21037957baf
---

 modules/gui/macosx/controls.m     |    2 --
 modules/gui/macosx/intf.m         |    9 ---------
 modules/gui/macosx/playlist.m     |    1 -
 modules/gui/minimal_macosx/intf.m |    5 -----
 4 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/modules/gui/macosx/controls.m b/modules/gui/macosx/controls.m
index 89d09cb..2020ad3 100644
--- a/modules/gui/macosx/controls.m
+++ b/modules/gui/macosx/controls.m
@@ -869,8 +869,6 @@
     assert([data isKindOfClass:[VLCAutoGeneratedMenuContent class]]);
     VLCAutoGeneratedMenuContent *menuContent = (VLCAutoGeneratedMenuContent *)data;
 
-    vlc_thread_set_priority( VLCIntf , VLC_THREAD_PRIORITY_LOW );
-
     p_object = [menuContent vlcObject];
 
     if( p_object != NULL )
diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
index 07aa547..e36d2f8 100644
--- a/modules/gui/macosx/intf.m
+++ b/modules/gui/macosx/intf.m
@@ -117,11 +117,6 @@ static void Run( intf_thread_t *p_intf )
 {
     sigset_t set;
 
-    /* Do it again - for some unknown reason, vlc_thread_create() often
-     * fails to go to real-time priority with the first launched thread
-     * (???) --Meuuh */
-    vlc_thread_set_priority( p_intf, VLC_THREAD_PRIORITY_LOW );
-
     /* Make sure the "force quit" menu item does quit instantly.
      * VLC overrides SIGTERM which is sent by the "force quit"
      * menu item to make sure deamon mode quits gracefully, so
@@ -565,8 +560,6 @@ static VLCMain *_o_sharedMainInstance = nil;
 
     [o_controls setupVarMenuItem: o_mi_add_intf target: (vlc_object_t *)p_intf
         var: "intf-add" selector: @selector(toggleVar:)];
-
-    vlc_thread_set_priority( p_intf, VLC_THREAD_PRIORITY_LOW );
 }
 
 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification
@@ -1613,8 +1606,6 @@ static void manage_cleanup( void * args )
 
     /* new thread requires a new pool */
 
-    vlc_thread_set_priority( p_intf, VLC_THREAD_PRIORITY_LOW );
-
     p_playlist = pl_Get( p_intf );
 
     var_AddCallback( p_playlist, "item-current", PlaylistChanged, self );
diff --git a/modules/gui/macosx/playlist.m b/modules/gui/macosx/playlist.m
index b3272a0..c5abc22 100644
--- a/modules/gui/macosx/playlist.m
+++ b/modules/gui/macosx/playlist.m
@@ -1520,7 +1520,6 @@
 - (IBAction)addNode:(id)sender
 {
     playlist_t * p_playlist = pl_Get( VLCIntf );
-    vlc_thread_set_priority( p_playlist, VLC_THREAD_PRIORITY_LOW );
 
     PL_LOCK;
     playlist_NodeCreate( p_playlist, _("Empty Folder"),
diff --git a/modules/gui/minimal_macosx/intf.m b/modules/gui/minimal_macosx/intf.m
index aa88eab..b9a13ef 100644
--- a/modules/gui/minimal_macosx/intf.m
+++ b/modules/gui/minimal_macosx/intf.m
@@ -125,11 +125,6 @@ static void Run( intf_thread_t *p_intf )
 {
     sigset_t set;
 
-    /* Do it again - for some unknown reason, vlc_thread_create() often
-     * fails to go to real-time priority with the first launched thread
-     * (???) --Meuuh */
-    vlc_thread_set_priority( p_intf, VLC_THREAD_PRIORITY_LOW );
-
     /* Make sure the "force quit" menu item does quit instantly.
      * VLC overrides SIGTERM which is sent by the "force quit"
      * menu item to make sure deamon mode quits gracefully, so