[vlc-commits] dbus: remove not thread-safe strerror() and GNU strerror_r() use

Rafaël Carré git at videolan.org
Tue May 31 19:14:28 CEST 2011


vlc | branch: master | Rafaël Carré <rafael.carre at gmail.com> | Mon May 30 23:06:04 2011 -0400| [db10bebafee251c87c8061c4a132307ec817ca8b] | committer: Rafaël Carré

dbus: remove not thread-safe strerror() and GNU strerror_r() use

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=db10bebafee251c87c8061c4a132307ec817ca8b
---

 modules/control/dbus/dbus.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/modules/control/dbus/dbus.c b/modules/control/dbus/dbus.c
index 1761ad8..945a915 100644
--- a/modules/control/dbus/dbus.c
+++ b/modules/control/dbus/dbus.c
@@ -870,8 +870,7 @@ static void Run          ( intf_thread_t *p_intf )
 
         if( -1 == i_pollres )
         { /* XXX: What should we do when poll() fails ? */
-            char buf[64];
-            msg_Err( p_intf, "poll() failed: %s", strerror_r( i_errsv, buf, 64 ) );
+            msg_Err( p_intf, "poll() failed: %m" );
             free( p_fds ); p_fds = NULL;
             vlc_restorecancel( canc );
             continue;
@@ -944,8 +943,7 @@ static void   wakeup_main_loop( void *p_data )
 
     if( !write( p_intf->p_sys->p_pipe_fds[PIPE_IN], "\0", 1 ) )
     {
-        msg_Err( p_intf,
-            "Could not wake up the main loop: %s", strerror( errno ) );
+        msg_Err( p_intf, "Could not wake up the main loop: %m" );
     }
 }
 



More information about the vlc-commits mailing list