[vlc-commits] win64 packaging: fix comment

Rafaël Carré git at videolan.org
Sun Nov 6 02:17:43 CET 2011


vlc | branch: master | Rafaël Carré <funman at videolan.org> | Sat Nov  5 21:06:37 2011 -0400| [dde3c27230cb444d07cc22f3c7835c6e5db88a9e] | committer: Rafaël Carré

win64 packaging: fix comment

It is not clear that static linking is superior in our case
Shared linking could even reduce package size (only one copy of libstdc++ shipped)

21:04 < jon_y> libtool prevents static linking if you are working with dlls, it is by
               design

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=dde3c27230cb444d07cc22f3c7835c6e5db88a9e
---

 Makefile.am |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 850cfb1..b28e441 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -752,9 +752,7 @@ endif
 # Compiler shared DLLs
 # For win64 only, Debian mingw32 compilers are built with --disable-shared
 if HAVE_WIN64
-#   if gcc_s_sjlj/stdc++ DLLs exist, we very likely linked our C++ modules to them
-#   FIXME : tell libtool to not use -nostdlib
-#   and add -static-libgcc and -static-libstdc++ to LDFLAGS
+#   if gcc_s_sjlj/stdc++ DLLs exist, our C++ modules were linked to them
 	gcc_lib_dir=`x86_64-w64-mingw32-gcc -v /dev/null 2>&1 | grep ^LIBRARY_PATH|cut -d= -f2|cut -d: -f1` ; \
 	cp "$${gcc_lib_dir}/libstdc++-6.dll" "$${gcc_lib_dir}/libgcc_s_sjlj-1.dll" "$(win32_destdir)/" ; true
 endif



More information about the vlc-commits mailing list