[vlc-commits] ActiveX: VLCPlugin was never destroyed. fixed

Sergey Radionov git at videolan.org
Tue Nov 8 02:23:37 CET 2011


npapi-vlc | branch: master | Sergey Radionov <RSATom at gmail.com> | Tue Aug 30 20:46:51 2011 +0700| [56caef7975e87e6e93d90b6355abd4d6fe4a2908] | committer: Jean-Baptiste Kempf

ActiveX: VLCPlugin was never destroyed. fixed

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/npapi-vlc.git/?a=commit;h=56caef7975e87e6e93d90b6355abd4d6fe4a2908
---

 activex/plugin.cpp |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/activex/plugin.cpp b/activex/plugin.cpp
index 8613eb1..5d53a40 100644
--- a/activex/plugin.cpp
+++ b/activex/plugin.cpp
@@ -229,11 +229,6 @@ VLCPlugin::VLCPlugin(VLCPluginClass *p_class, LPUNKNOWN pUnkOuter) :
     _b_usermode(TRUE),
     _WindowsManager(DllGetModule())
 {
-    /*
-    ** bump refcount to avoid recursive release from
-    ** following interfaces when releasing this interface
-    */
-    AddRef();
     p_class->AddRef();
 
     vlcOleControl = new VLCOleControl(this);
@@ -299,7 +294,6 @@ VLCPlugin::~VLCPlugin()
     if( _p_libvlc )  { libvlc_release(_p_libvlc); _p_libvlc=NULL; }
 
     _p_class->Release();
-    Release();
 };
 
 STDMETHODIMP VLCPlugin::QueryInterface(REFIID riid, void **ppv)



More information about the vlc-commits mailing list