[vlc-commits] Win32: do not set _fmode
Rémi Denis-Courmont
git at videolan.org
Tue Nov 22 17:17:53 CET 2011
vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov 22 18:12:42 2011 +0200| [1c8b5fc1a42fe3e165ef581aff132b10d9fd5b4d] | committer: Rémi Denis-Courmont
Win32: do not set _fmode
Setting the translation mode is the responsibility of the program. A
library must not interfere with that. It could perhaps be added to VLC.
However it should not be required as we now force binary mode by
default in vlc_fopen() and always specify an explicit mode when calling
fopen() directly. Also it would make VLC behave differently than other
LibVLC applications, which may raise really weird bugs.
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1c8b5fc1a42fe3e165ef581aff132b10d9fd5b4d
---
src/win32/specific.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/win32/specific.c b/src/win32/specific.c
index 2d82256..df6ab9b 100644
--- a/src/win32/specific.c
+++ b/src/win32/specific.c
@@ -34,8 +34,6 @@
#include "../config/vlc_getopt.h"
#if !defined( UNDER_CE )
-# include <io.h>
-# include <fcntl.h>
# include <mmsystem.h>
#endif
@@ -82,7 +80,6 @@ void system_Init( void )
/* Set the default file-translation mode */
#if !defined( UNDER_CE )
- _fmode = _O_BINARY;
timeBeginPeriod(5);
#endif
More information about the vlc-commits
mailing list