[vlc-commits] Fix corner case crash on corrupt plugin with callbacks

Rémi Denis-Courmont git at videolan.org
Fri Oct 7 22:21:39 CEST 2011


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri Oct  7 19:38:27 2011 +0300| [4c9e1a93079d23a38d57770b94b9b8c50858ca0e] | committer: Rémi Denis-Courmont

Fix corner case crash on corrupt plugin with callbacks

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4c9e1a93079d23a38d57770b94b9b8c50858ca0e
---

 src/modules/bank.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/modules/bank.c b/src/modules/bank.c
index 61e5a35..b6cf6d0 100644
--- a/src/modules/bank.c
+++ b/src/modules/bank.c
@@ -492,6 +492,8 @@ static int AllocatePluginFile (module_bank_t *bank, const char *abspath,
              /* !unloadable not allowed for plugins with callbacks */
              vlc_module_destroy (module);
              module = module_InitDynamic (bank->obj, abspath, false);
+             if (unlikely(module == NULL))
+                 return -1;
              break;
          }
 



More information about the vlc-commits mailing list