[vlc-commits] Fix bug in HTML construction that resulted in malformed HTML (CC)

[Devin Heitmueller]

vlc | branch: master | Devin Heitmueller <dheitmueller at kernellabs.com> | Tue Sep 13 00:22:47 2011 +0200| [510a29d8dd8d3969fa74557cad18afa3d2ec48ad] | committer: Laurent Aimar

Fix bug in HTML construction that resulted in malformed HTML (CC)

Address a case where we would end up with missing closing underline tags.  This
results in malformed HTML causing the subpicture to never be rendered in those
cases.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=510a29d8dd8d3969fa74557cad18afa3d2ec48ad
---

 modules/codec/cc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/codec/cc.c b/modules/codec/cc.c
index e18a6d6..ff17c00 100644
--- a/modules/codec/cc.c
+++ b/modules/codec/cc.c
@@ -974,7 +974,7 @@ static void Eia608TextLine( struct eia608_screen *screen, char *psz_text, int i_
 
             /* Be sure to create valid html */
             b_close_italics |= b_last_italics && b_close_color;
-            b_close_underline = b_last_underline && ( b_close_italics || b_close_color );
+            b_close_underline |= b_last_underline && ( b_close_italics || b_close_color );
 
             if( b_close_underline )
                 CAT( "</u>" );