[vlc-commits] skins2: fix forgotten initialization in copy constructor

Erwan Tulou git at videolan.org
Wed Apr 11 19:12:25 CEST 2012


vlc/vlc-2.0 | branch: master | Erwan Tulou <erwan10 at videolan.org> | Tue Apr 10 18:02:29 2012 +0200| [2eaee5286a71d0dc6a618f54aa0a6bf69ad64d36] | committer: Jean-Baptiste Kempf

skins2: fix forgotten initialization in copy constructor

This bug was unnoticed because this constructor is only called in a situation
where really copying from origin or leaving it to the compiler to set it via
the default constructor leads to the same result (an empty list). Yet, this
was a bug.

It may solve trac #6599 though,
(a Linux port where there is a real initialization issue)
(cherry picked from commit 076851b74bee39d0c911a344063f5e4731dda28a)

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.0.git/?a=commit;h=2eaee5286a71d0dc6a618f54aa0a6bf69ad64d36
---

 modules/gui/skins2/utils/var_tree.cpp |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/modules/gui/skins2/utils/var_tree.cpp b/modules/gui/skins2/utils/var_tree.cpp
index bf47685..025876a 100644
--- a/modules/gui/skins2/utils/var_tree.cpp
+++ b/modules/gui/skins2/utils/var_tree.cpp
@@ -58,7 +58,8 @@ VarTree::VarTree( intf_thread_t *pIntf, VarTree *pParent, int id,
 }
 
 VarTree::VarTree( const VarTree& v )
-    : Variable( v.getIntf() ), m_pParent( v.m_pParent ),
+    : Variable( v.getIntf() ),
+      m_children( v.m_children), m_pParent( v.m_pParent ),
       m_id( v.m_id ), m_cString( v.m_cString ),
       m_readonly( v.m_readonly ), m_selected( v.m_selected ),
       m_playing( v.m_playing ), m_expanded( v.m_expanded ),



More information about the vlc-commits mailing list