[vlc-commits] mod: do not attempt to parse standard MIDI files

Rémi Denis-Courmont git at videolan.org
Wed Aug 8 09:44:59 CEST 2012


vlc/vlc-2.0 | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Aug  8 10:41:19 2012 +0300| [42793363cb27c60e0f43cb7e045d5db979e5730a] | committer: Rémi Denis-Courmont

mod: do not attempt to parse standard MIDI files

VLC has a native parser with higher priority. So ModPlug only got to
parse the broken files that VLC rejected. ModPlug is not robust and it
crashes in that case.
(cherry picked from commit 76b15d4038e1f2200ab463c275c0854848de8671)

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.0.git/?a=commit;h=42793363cb27c60e0f43cb7e045d5db979e5730a
---

 modules/demux/mod.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/demux/mod.c b/modules/demux/mod.c
index 6514b78..beff625 100644
--- a/modules/demux/mod.c
+++ b/modules/demux/mod.c
@@ -447,7 +447,6 @@ static int Validate( demux_t *p_demux, const char *psz_ext )
         {  0, "Extended Module" },      /* XM */
         { 44, "SCRM" },                 /* S3M */
         {  0, "IMPM" },                 /* IT */
-        {  0, "MThd" },                 /* MID */
         {  0, "GF1PATCH110" },          /* PAT */
         { 20, "!SCREAM!" },             /* STM */
         { 20, "!Scream!" },             /* STM */



More information about the vlc-commits mailing list