[vlc-commits] libvlc: do not assume playlist exists when preparsing

Rémi Denis-Courmont git at videolan.org
Tue Aug 21 20:32:26 CEST 2012


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Aug 21 20:56:23 2012 +0300| [f843903810b57282683237a224dbb50637cc0c69] | committer: Rémi Denis-Courmont

libvlc: do not assume playlist exists when preparsing

This could crash. The playlist needs to be started (at least until
someone resolves bug #5460).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f843903810b57282683237a224dbb50637cc0c69
---

 lib/media.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/media.c b/lib/media.c
index fc32c67..600e10a 100644
--- a/lib/media.c
+++ b/lib/media.c
@@ -591,8 +591,8 @@ libvlc_media_get_duration( libvlc_media_t * p_md )
 static int media_parse(libvlc_media_t *media)
 {
     /* TODO: fetcher and parser independent of playlist */
-    playlist_t *playlist =
-        libvlc_priv (media->p_libvlc_instance->p_libvlc_int)->p_playlist;
+#warning FIXME: remove pl_Get
+    playlist_t *playlist = pl_Get(media->p_libvlc_instance->p_libvlc_int);
 
     /* TODO: Fetch art on need basis. But how not to break compatibility? */
     playlist_AskForArtEnqueue(playlist, media->p_input_item );



More information about the vlc-commits mailing list