[vlc-commits] PulseAudio: force minreq to less than half tlength (refs #7827)

Rémi Denis-Courmont git at videolan.org
Thu Dec 6 22:37:05 CET 2012


vlc/vlc-1.1 | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Dec  6 23:31:54 2012 +0200| [6e630745e8051454258bb2882ff8960d30aa87cd] | committer: Rémi Denis-Courmont

PulseAudio: force minreq to less than half tlength (refs #7827)

This should work-around distorsion due to excessively short latency
computation in PulseAudio, e.g. NVIDIA HDMI Audio.

In the longer term, VLC should probably set minreq to 40ms and tlength
to a larger value or even -1. But that would require more testing.
(cherry picked from commit a1ddda85bb3cbd7ec4b7bb0aa0fd80c9a6d3afe7)

> http://git.videolan.org/gitweb.cgi/vlc/vlc-1.1.git/?a=commit;h=6e630745e8051454258bb2882ff8960d30aa87cd
---

 modules/audio_output/pulse.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/audio_output/pulse.c b/modules/audio_output/pulse.c
index 3a847f5..f44d732 100644
--- a/modules/audio_output/pulse.c
+++ b/modules/audio_output/pulse.c
@@ -586,7 +586,7 @@ static int Open(vlc_object_t *obj)
      * TODO? tlength could be adaptively increased to reduce wakeups. */
     attr.tlength = byterate * AOUT_MIN_PREPARE_TIME / CLOCK_FREQ;
     attr.prebuf = 0; /* trigger manually */
-    attr.minreq = -1;
+    attr.minreq = attr.tlength / 3;
     attr.fragsize = 0; /* not used for output */
 
     /* Allocate structures */



More information about the vlc-commits mailing list