[vlc-commits] vout: do not set "fullscreen" variable again (fixes #7926)

Rémi Denis-Courmont git at videolan.org
Wed Dec 19 17:41:06 CET 2012


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Dec 19 18:38:10 2012 +0200| [6a0f8ab4b22097392d10cd8931eeb56bfe7e4ebf] | committer: Rémi Denis-Courmont

vout: do not set "fullscreen" variable again (fixes #7926)

The "fullscreen" variable is set by the UI. That triggers a vout
control request. Then the vout thread actually switches to/from
full screen mode. Setting the "fullscreen" variable again then would
trigger a live loop in some circumstances, and should be useless.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6a0f8ab4b22097392d10cd8931eeb56bfe7e4ebf
---

 src/video_output/video_output.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index b83d040..0c56ef9 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -1268,8 +1268,6 @@ static void ThreadStep(vout_thread_t *vout, mtime_t *duration)
 
 static void ThreadChangeFullscreen(vout_thread_t *vout, bool fullscreen)
 {
-    /* FIXME not sure setting "fullscreen" is good ... */
-    var_SetBool(vout, "fullscreen", fullscreen);
     vout_SetDisplayFullscreen(vout->p->display.vd, fullscreen);
 }
 



More information about the vlc-commits mailing list