[vlc-commits] Make sure font color attribute is quoted.

Devin Heitmueller git at videolan.org
Mon Dec 31 14:00:04 CET 2012


vlc | branch: master | Devin Heitmueller <dheitmueller at kernellabs.com> | Thu Dec 27 01:08:19 2012 -0500| [2393f44266d735bc93e2dedb7491c461834e946d] | committer: Rafaël Carré

Make sure font color attribute is quoted.

We need to add quotes to the color attribute for the font tag, or else
the XML parser will choke and the HTML will not be rendered.

Signed-off-by: Rafaël Carré <funman at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2393f44266d735bc93e2dedb7491c461834e946d
---

 modules/codec/cc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/codec/cc.c b/modules/codec/cc.c
index 74a35d9..5366fb4 100644
--- a/modules/codec/cc.c
+++ b/modules/codec/cc.c
@@ -986,9 +986,9 @@ static void Eia608TextLine( struct eia608_screen *screen, char *psz_text, int i_
                     "#ff00ff",  // magenta
                     "#ffffff",  // user defined XXX we use white
                 };
-                CAT( "<font color=" );
+                CAT( "<font color=\"" );
                 CAT( ppsz_color[color] );
-                CAT( ">" );
+                CAT( "\">" );
             }
             if( ( b_close_italics && b_italics ) || ( b_italics && !b_last_italics ) )
                 CAT( "<i>" );



More information about the vlc-commits mailing list