[vlc-commits] Qt4: add item options for all items

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Feb  9 23:20:44 2012 +0200| [801dec3decd603f5bf1b0e77c25708e6e333cf22] | committer: Rémi Denis-Courmont

Qt4: add item options for all items

There are no reasons to only apply them to the first one. Certainly
some options might only make sense with a single item. But then it
really boils down to having only one item. Some options *do* make
sense for all (>1) items.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=801dec3decd603f5bf1b0e77c25708e6e333cf22
---

 modules/gui/qt4/dialogs/open.cpp |   25 ++++++++++---------------
 1 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/modules/gui/qt4/dialogs/open.cpp b/modules/gui/qt4/dialogs/open.cpp
index 7d75fd7..610c19b 100644
--- a/modules/gui/qt4/dialogs/open.cpp
+++ b/modules/gui/qt4/dialogs/open.cpp
@@ -372,25 +372,20 @@ void OpenDialog::enqueue( bool b_enqueue )
         input_item_t *p_input;
         p_input = input_item_New( qtu( itemsMRL[i] ), NULL );
 
-        /* Insert options only for the first element.
-           We don't know how to edit that anyway. */
-        if( i == 0 )
-        {
-            /* Take options from the UI, not from what we stored */
-            QStringList optionsList = ui.advancedLineInput->text().split( " :" );
+        /* Take options from the UI, not from what we stored */
+        QStringList optionsList = ui.advancedLineInput->text().split( " :" );
 
-            /* Insert options */
-            for( int j = 0; j < optionsList.count(); j++ )
+        /* Insert options */
+        for( int j = 0; j < optionsList.count(); j++ )
+        {
+            QString qs = colon_unescape( optionsList[j] );
+            if( !qs.isEmpty() )
             {
-                QString qs = colon_unescape( optionsList[j] );
-                if( !qs.isEmpty() )
-                {
-                    input_item_AddOption( p_input, qtu( qs ),
-                                          VLC_INPUT_OPTION_TRUSTED );
+                input_item_AddOption( p_input, qtu( qs ),
+                                      VLC_INPUT_OPTION_TRUSTED );
 #ifdef DEBUG_QT
-                    msg_Warn( p_intf, "Input option: %s", qtu( qs ) );
+                msg_Warn( p_intf, "Input option: %s", qtu( qs ) );
 #endif
-                }
             }
         }