[vlc-commits] Fix inverted shell negation "! test" -> "test !"

Rémi Denis-Courmont git at videolan.org
Tue Feb 28 17:36:44 CET 2012


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Feb 28 18:28:09 2012 +0200| [3e48c330dccfb4d90e0b3d97308038b6de3b570b] | committer: Rémi Denis-Courmont

Fix inverted shell negation "! test" -> "test !"

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3e48c330dccfb4d90e0b3d97308038b6de3b570b
---

 configure.ac                                       |    6 +++---
 modules/genmf                                      |    2 +-
 projects/macosx/framework/Pre-Compile.sh           |    4 ++--
 .../frontrow_plugin/BackRowHeaders/install.sh      |    2 +-
 .../stream_filter/httplive/traffic-shaping.sh      |    2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6d2562c..efb2e99 100644
--- a/configure.ac
+++ b/configure.ac
@@ -174,7 +174,7 @@ case "${host_os}" in
       [AS_HELP_STRING([--with-macosx-sdk=DIR],
         [compile using the SDK in DIR])])
     test "${with_macosx_sdk}" = "" && with_macosx_sdk=/Developer/SDKs/MacOSX10.6.sdk
-    ! test -d "${with_macosx_sdk}" && AC_MSG_ERROR([SDK "${with_macosx_sdk}" not found])
+    test ! -d "${with_macosx_sdk}" && AC_MSG_ERROR([SDK "${with_macosx_sdk}" not found])
     AC_ARG_WITH(macosx-version-min,
       [AS_HELP_STRING([--with-macosx-version-min=VERSION],
         [compile for MacOS X VERSION and above])])
@@ -3693,14 +3693,14 @@ then
 
   VLC_ADD_LIBS([macosx], [-Wl,-framework,QTKit -Wl,-framework,IOKit -Wl,-framework,AddressBook -Wl,-framework,WebKit])
 
-  if ! test -d ${CONTRIB_DIR}/Sparkle.framework
+  if test ! -d ${CONTRIB_DIR}/Sparkle.framework
   then
     AC_MSG_ERROR([Sparkle framework is required and was not found in ${CONTRIB_DIR}])
   fi
   VLC_ADD_LIBS([macosx], [-F${CONTRIB_DIR} -Wl,-framework,Sparkle])
   VLC_ADD_OBJCFLAGS([macosx], [-F${CONTRIB_DIR}])
 
-  if ! test -d ${CONTRIB_DIR}/BGHUDAppKit.framework
+  if test ! -d ${CONTRIB_DIR}/BGHUDAppKit.framework
   then
     AC_MSG_ERROR([BGHUDAppKit framework is required and was not found in ${CONTRIB_DIR}])
   fi
diff --git a/modules/genmf b/modules/genmf
index aefd560..67fe47c 100755
--- a/modules/genmf
+++ b/modules/genmf
@@ -13,7 +13,7 @@ while test "$1"
 do
   dir="$1"
   modf="modules/${dir}/Modules.am"
-  if ! test -f "$modf"; then
+  if test ! -f "$modf"; then
     echo "$modf does not exist!" >&2
     exit 1
   fi
diff --git a/projects/macosx/framework/Pre-Compile.sh b/projects/macosx/framework/Pre-Compile.sh
index 9de7321..1b4fa3d 100644
--- a/projects/macosx/framework/Pre-Compile.sh
+++ b/projects/macosx/framework/Pre-Compile.sh
@@ -88,11 +88,11 @@ vlc_install_object() {
         local lib_install_prefix="@loader_path/../lib"
     fi
 
-    if ! test -e ${src_lib}; then
+    if test ! -e ${src_lib}; then
         return
     fi
 
-    if ( (! test -e ${lib_dest}) || test ${src_lib} -nt ${lib_dest} ); then
+    if ( (test ! -e ${lib_dest}) || test ${src_lib} -nt ${lib_dest} ); then
 
         mkdir -p ${dest_dir}
 
diff --git a/projects/macosx/frontrow_plugin/BackRowHeaders/install.sh b/projects/macosx/frontrow_plugin/BackRowHeaders/install.sh
index 4c49e3e..f77c244 100755
--- a/projects/macosx/frontrow_plugin/BackRowHeaders/install.sh
+++ b/projects/macosx/frontrow_plugin/BackRowHeaders/install.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-if ! test -e $PWD/Headers/BREvent.h; then
+if test ! -e $PWD/Headers/BREvent.h; then
     echo "Please run this script from BackRowHeaders directory"
     exit 1
 else
diff --git a/test/modules/stream_filter/httplive/traffic-shaping.sh b/test/modules/stream_filter/httplive/traffic-shaping.sh
index cf67c89..1b63c91 100755
--- a/test/modules/stream_filter/httplive/traffic-shaping.sh
+++ b/test/modules/stream_filter/httplive/traffic-shaping.sh
@@ -34,7 +34,7 @@ function traffic_shaping() {
 # tc qdisc add dev eth2 root tbf rate 50kbit burst 2kbit latency 70ms peakrate 52kbit mtu 1500
 
 traffic_shaping
-if ! test "${RESULT}" = "0"; then
+if test "${RESULT}" != "0"; then
     exit 1
 fi
 exit 0



More information about the vlc-commits mailing list