[vlc-commits] macosx: fixed unresponsive playlist correlated to video playback ( fixes #5871)

Felix Paul Kühne git at videolan.org
Sat Jan 21 00:13:35 CET 2012


vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Fri Jan 20 10:26:54 2012 -0800| [3ab779178263e7831e9e1d38b618428d0d44dad9] | committer: Felix Paul Kühne

macosx: fixed unresponsive playlist correlated to video playback (fixes #5871)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3ab779178263e7831e9e1d38b618428d0d44dad9
---

 modules/gui/macosx/MainWindow.m |    4 ++++
 modules/gui/macosx/VideoView.m  |    5 ++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/modules/gui/macosx/MainWindow.m b/modules/gui/macosx/MainWindow.m
index 4b751b4..2463f13 100644
--- a/modules/gui/macosx/MainWindow.m
+++ b/modules/gui/macosx/MainWindow.m
@@ -559,11 +559,13 @@ static VLCMainWindow *_o_sharedInstance = nil;
         if ([o_video_view isHidden] && [o_playlist_btn isEnabled]) {
             [o_split_view setHidden: YES];
             [o_video_view setHidden: NO];
+            [self makeFirstResponder: o_video_view];
         }
         else
         {
             [o_video_view setHidden: YES];
             [o_split_view setHidden: NO];
+            [self makeFirstResponder: nil];
         }
     }
     else
@@ -1193,6 +1195,8 @@ static VLCMainWindow *_o_sharedInstance = nil;
     }
     if (b_videoPlayback)
         [self makeFirstResponder: o_video_view];
+    else
+        [self makeFirstResponder: nil];
 }
 
 - (void)resizeWindow
diff --git a/modules/gui/macosx/VideoView.m b/modules/gui/macosx/VideoView.m
index dbe67ab..a3200ba 100644
--- a/modules/gui/macosx/VideoView.m
+++ b/modules/gui/macosx/VideoView.m
@@ -304,8 +304,7 @@ int DeviceCallback( vlc_object_t *p_this, const char *psz_variable,
 
 - (BOOL)resignFirstResponder
 {
-    /* We need to stay the first responder or we'll miss some
-       events */
-    return NO;
+    /* while we need to be the first responder most of the time, we need to give up that status when toggling the playlist */
+    return YES;
 }
 @end



More information about the vlc-commits mailing list