[vlc-commits] rand: Also use /dev/urandom on OpenBSD as well

Brad Smith git at videolan.org
Sun Jan 29 09:22:59 CET 2012


vlc | branch: master | Brad Smith <brad at comstyle.com> | Sat Jan 28 20:54:14 2012 -0500| [3fc4af487dc23113a3c9602e1022f464f3992601] | committer: Rémi Denis-Courmont

rand: Also use /dev/urandom on OpenBSD as well

On older OpenBSD releases you especially should not have been
using /dev/random, nowdays due to changes all the device nodes
are actually all the same so either way this code can be simplified
to not special case OpenBSD in vlc_rand_init().

Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3fc4af487dc23113a3c9602e1022f464f3992601
---

 src/posix/rand.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/src/posix/rand.c b/src/posix/rand.c
index fbf020f..af448fb 100644
--- a/src/posix/rand.c
+++ b/src/posix/rand.c
@@ -49,15 +49,10 @@ static uint8_t okey[BLOCK_SIZE], ikey[BLOCK_SIZE];
 
 static void vlc_rand_init (void)
 {
-#if defined (__OpenBSD__) || defined (__OpenBSD_kernel__)
-    static const char randfile[] = "/dev/random";
-#else
-    static const char randfile[] = "/dev/urandom";
-#endif
     uint8_t key[BLOCK_SIZE];
 
     /* Get non-predictible value as key for HMAC */
-    int fd = vlc_open (randfile, O_RDONLY);
+    int fd = vlc_open ("/dev/urandom", O_RDONLY);
     if (fd == -1)
         return; /* Uho! */
 



More information about the vlc-commits mailing list