[vlc-commits] Win32: do not override LC_ALL

Rémi Denis-Courmont git at videolan.org
Thu Jul 12 21:55:55 CEST 2012


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Jul 12 22:40:54 2012 +0300| [94d79d31c48cc980d819b5c0f47eba2966969203] | committer: Rémi Denis-Courmont

Win32: do not override LC_ALL

This code might have had some effects on some other OS (BeOS?), but
it should not be required on Windows. Also good-mannered and
thread-safe libraries do not modify the environment.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=94d79d31c48cc980d819b5c0f47eba2966969203
---

 src/libvlc.c |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/libvlc.c b/src/libvlc.c
index 49220ab..3a321c7 100644
--- a/src/libvlc.c
+++ b/src/libvlc.c
@@ -821,13 +821,6 @@ static void SetLanguage ( const char *psz_lang )
      * other platforms. --Meuuh */
     setenv( "LANG", psz_lang, 1 );
 
-#else
-    /* We set LC_ALL manually because it is the only way to set
-     * the language at runtime under eg. Windows. Beware that this
-     * makes the environment unconsistent when libvlc is unloaded and
-     * should probably be moved to a safer place like vlc.c. */
-    setenv( "LC_ALL", psz_lang, 1 );
-
 #endif
 
     setlocale( LC_ALL, psz_lang );



More information about the vlc-commits mailing list