[vlc-commits] macosx: expand the documentation for our single (known) private API use

[Felix Paul Kühne]

vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Mon Jun 25 19:01:21 2012 +0200| [960e3780ceab96d45d9887a0149686f9940b825d] | committer: Felix Paul Kühne

macosx: expand the documentation for our single (known) private API use

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=960e3780ceab96d45d9887a0149686f9940b825d
---

 modules/gui/macosx/playlist.m |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/modules/gui/macosx/playlist.m b/modules/gui/macosx/playlist.m
index 618a156..0b301ee 100644
--- a/modules/gui/macosx/playlist.m
+++ b/modules/gui/macosx/playlist.m
@@ -430,10 +430,11 @@
 @end
 
 /*****************************************************************************
- * extension to NSOutlineView's interface to fix compilation warnings
- * and let us access these 2 functions properly
- * this uses a private Apple-API, but works fine on all current OSX releases
- * keep checking for compatiblity with future releases though
+ * An extension to NSOutlineView's interface to fix compilation warnings
+ * and let us access these 2 functions properly.
+ * This uses a private API, but works fine on all current OSX releases.
+ * Radar ID 11739459 request a public API for this. However, it is probably
+ * easier and faster to recreate similar looking bitmaps ourselves.
  *****************************************************************************/
 
 @interface NSOutlineView (UndocumentedSortImages)
@@ -498,9 +499,9 @@
       @"VLCPlaylistItemPboardType", nil]];
     [o_outline_view_other setIntercellSpacing: NSMakeSize (0.0, 1.0)];
 
-    /* This uses private Apple API which works fine until 10.5.
-     * We need to keep checking in the future!
-     * These methods are being added artificially to NSOutlineView's interface above */
+    /* This uses a private API, but works fine on all current OSX releases.
+     * Radar ID 11739459 request a public API for this. However, it is probably
+     * easier and faster to recreate similar looking bitmaps ourselves. */
     o_ascendingSortingImage = [[NSOutlineView class] _defaultTableHeaderSortImage];
     o_descendingSortingImage = [[NSOutlineView class] _defaultTableHeaderReverseSortImage];