[vlc-commits] qt4: do not compute more than one time the lenght of the same string.

Rémi Duraffort git at videolan.org
Thu Jun 28 20:13:45 CEST 2012


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Thu Jun 28 10:36:05 2012 +0200| [b22aee779cc4bc55f7ce638cf14c6f418fd60395] | committer: Rémi Duraffort

qt4: do not compute more than one time the lenght of the same string.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b22aee779cc4bc55f7ce638cf14c6f418fd60395
---

 modules/gui/qt4/components/extended_panels.cpp |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/gui/qt4/components/extended_panels.cpp b/modules/gui/qt4/components/extended_panels.cpp
index 508f1f6..7bc8998 100644
--- a/modules/gui/qt4/components/extended_panels.cpp
+++ b/modules/gui/qt4/components/extended_panels.cpp
@@ -362,10 +362,10 @@ static void ChangeVFiltersString( struct intf_thread_t *p_intf, const char *psz_
             }
 
             /* Remove trailing : : */
-            if( strlen( psz_string ) > 0 &&
-                *( psz_string + strlen( psz_string ) -1 ) == ':' )
+            size_t i_len = strlen( psz_string );
+            if( i_len > 0 && *( psz_string + i_len - 1 ) == ':' )
             {
-                *( psz_string + strlen( psz_string ) -1 ) = '\0';
+                *( psz_string + i_len - 1 ) = '\0';
             }
         }
         else



More information about the vlc-commits mailing list