[vlc-commits] Spatializer: more sane default for Wet value and limit all values

[Jean-Baptiste Kempf]

vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Tue Mar 27 20:13:19 2012 +0200| [be8542ade356de4fa218b03df22747182bcbe9a0] | committer: Jean-Baptiste Kempf

Spatializer: more sane default for Wet value and limit all values

I am not sure this filter ever worked as intended.
It was providing serious distortions.

This is now limiting seriously the space of parameters but at least it
does not explode anymore. Should close #4887

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=be8542ade356de4fa218b03df22747182bcbe9a0
---

 modules/audio_filter/spatializer/spatializer.cpp |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/modules/audio_filter/spatializer/spatializer.cpp b/modules/audio_filter/spatializer/spatializer.cpp
index 45658e3..dee38c5 100644
--- a/modules/audio_filter/spatializer/spatializer.cpp
+++ b/modules/audio_filter/spatializer/spatializer.cpp
@@ -76,12 +76,16 @@ vlc_module_begin ()
 
     set_callbacks( Open, Close )
     add_shortcut( "spatializer" )
-    add_float( "spatializer-roomsize", 1.05, ROOMSIZE_TEXT,
-               ROOMSIZE_LONGTEXT, true )
-    add_float( "spatializer-width", 10., WIDTH_TEXT,WIDTH_LONGTEXT, true )
-    add_float( "spatializer-wet", 3., WET_TEXT,WET_LONGTEXT, true )
-    add_float( "spatializer-dry", 2., DRY_TEXT,DRY_LONGTEXT, true )
-    add_float_with_range( "spatializer-damp", 1., 0., 4., DAMP_TEXT,DAMP_LONGTEXT, true )
+    add_float_with_range( "spatializer-roomsize", 0.85, 0., 1.1,
+                            ROOMSIZE_TEXT, ROOMSIZE_LONGTEXT, false )
+    add_float_with_range( "spatializer-width", 1,     0.,  1.,
+                            WIDTH_TEXT,WIDTH_LONGTEXT, false )
+    add_float_with_range( "spatializer-wet",   0.4,   0.,  1.,
+                            WET_TEXT,WET_LONGTEXT, false )
+    add_float_with_range( "spatializer-dry",   0.5,   0.,  1.,
+                            DRY_TEXT,DRY_LONGTEXT, false )
+    add_float_with_range( "spatializer-damp",  0.5,   0.,  1.,
+                            DAMP_TEXT,DAMP_LONGTEXT, false )
 vlc_module_end ()
 
 /*****************************************************************************