[vlc-commits] file aout: do not apply volume (refs #6262)

Rémi Denis-Courmont git at videolan.org
Mon May 7 17:24:50 CEST 2012


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun May  6 15:17:30 2012 +0300| [02a2074e054a237876a2c980621cbc0969dd72a4] | committer: Rémi Denis-Courmont

file aout: do not apply volume (refs #6262)

In my opinion, amplifying the audio that gets recorded to a file may do
more harm than good. Indeed, there is no direct feedback to detect and
correct saturation or distortion.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=02a2074e054a237876a2c980621cbc0969dd72a4
---

 modules/audio_output/file.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/modules/audio_output/file.c b/modules/audio_output/file.c
index fb56805..e2c4e31 100644
--- a/modules/audio_output/file.c
+++ b/modules/audio_output/file.c
@@ -193,10 +193,8 @@ static int Open( vlc_object_t * p_this )
     {
         p_aout->format.i_bytes_per_frame = AOUT_SPDIF_SIZE;
         p_aout->format.i_frame_length = A52_FRAME_NB;
-        aout_VolumeNoneInit( p_aout );
     }
-    else
-        aout_VolumeSoftInit( p_aout );
+    aout_VolumeNoneInit( p_aout );
 
     /* Channels number */
     i_channels = var_CreateGetInteger( p_this, "audiofile-channels" );



More information about the vlc-commits mailing list