[vlc-commits] remap: setup filter_t only when successful

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov  6 19:35:43 2012 +0200| [e5acfdd22ec17a986ff1c7324c542624cdb5af43] | committer: Rémi Denis-Courmont

remap: setup filter_t only when successful

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e5acfdd22ec17a986ff1c7324c542624cdb5af43
---

 modules/audio_filter/channel_mixer/remap.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/audio_filter/channel_mixer/remap.c b/modules/audio_filter/channel_mixer/remap.c
index 9566700..ef5473e 100644
--- a/modules/audio_filter/channel_mixer/remap.c
+++ b/modules/audio_filter/channel_mixer/remap.c
@@ -338,7 +338,6 @@ static int OpenFilter( vlc_object_t *p_this )
              aout_FormatPrintChannels( audio_in ),
              aout_FormatPrintChannels( audio_out ) );
 
-    p_filter->pf_audio_filter = Remap;
     p_sys->pf_remap = GetRemapFun( audio_in, b_multiple );
     if( !p_sys->pf_remap )
     {
@@ -347,7 +346,8 @@ static int OpenFilter( vlc_object_t *p_this )
         return VLC_EGENERIC;
     }
 
-    return 0;
+    p_filter->pf_audio_filter = Remap;
+    return VLC_SUCCESS;
 }
 
 /*****************************************************************************