[vlc-commits] v4l2: do not warn about unsupported CROPCAP, only print debug

Rémi Denis-Courmont git at videolan.org
Tue Sep 4 15:09:36 CEST 2012


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Sep  4 15:54:39 2012 +0300| [775d319e2f75dcdc6ca25af06414c337979aa4f7] | committer: Rémi Denis-Courmont

v4l2: do not warn about unsupported CROPCAP, only print debug

CROPCAP is no longer mandatory, and many drivers failed to provide it.
If there is no CROPCAP, then there is no cropping.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=775d319e2f75dcdc6ca25af06414c337979aa4f7
---

 modules/access/v4l2/video.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/access/v4l2/video.c b/modules/access/v4l2/video.c
index b17765f..7d7bab6 100644
--- a/modules/access/v4l2/video.c
+++ b/modules/access/v4l2/video.c
@@ -216,8 +216,8 @@ static int ResetCrop (vlc_object_t *obj, int fd)
      * In practice, it does not. */
     if (v4l2_ioctl (fd, VIDIOC_CROPCAP, &cropcap) < 0)
     {
-        msg_Warn (obj, "cannot get cropping properties: %m");
-        return -1;
+        msg_Dbg (obj, "cannot get cropping properties: %m");
+        return 0;
     }
 
     /* Reset to the default cropping rectangle */



More information about the vlc-commits mailing list