[vlc-commits] vout: fix use-after-free of SPU

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Aug  8 22:07:00 2013 +0300| [41dc3d2b719b31b2ff34f983fb21f15a9ca97085] | committer: Rémi Denis-Courmont

vout: fix use-after-free of SPU

Pointed-out-by: Pedro Ribeiro <pedrib at gmail.com>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=41dc3d2b719b31b2ff34f983fb21f15a9ca97085
---

 src/video_output/video_output.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index c0401c1..f774b2d 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -1024,7 +1024,10 @@ static int ThreadDisplayRenderPicture(vout_thread_t *vout, bool is_forced)
             vout_display_Prepare(vd, sys->display.filtered, do_dr_spu ? subpic : NULL);
         }
         if (!do_dr_spu && subpic)
+        {
             subpicture_Delete(subpic);
+            subpic = NULL;
+        }
         if (!sys->display.filtered)
             return VLC_EGENERIC;
     }