[vlc-commits] macosx: fix potential string format attack

David Fuhrmann git at videolan.org
Sun Aug 25 18:22:22 CEST 2013


vlc/vlc-2.1 | branch: master | David Fuhrmann <david.fuhrmann at googlemail.com> | Sat Aug 24 09:13:03 2013 +0200| [27f3a32a31da98c3d475f2e663ce3a3244cdff4e] | committer: Jean-Baptiste Kempf

macosx: fix potential string format attack

(cherry picked from commit 3fc6c045c3df9a04a4f018fe6b3a657755460bb1)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.1.git/?a=commit;h=27f3a32a31da98c3d475f2e663ce3a3244cdff4e
---

 modules/gui/macosx/coredialogs.m |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/macosx/coredialogs.m b/modules/gui/macosx/coredialogs.m
index 0f3961d..8e4a79f 100644
--- a/modules/gui/macosx/coredialogs.m
+++ b/modules/gui/macosx/coredialogs.m
@@ -107,7 +107,7 @@ static VLCCoreDialogProvider *_o_sharedInstance = nil;
     NSAlert *o_alert;
     NSInteger i_returnValue = 0;
   
-    o_alert = [NSAlert alertWithMessageText: toNSStr(p_dialog->title) defaultButton: toNSStr(p_dialog->yes) alternateButton: toNSStr(p_dialog->no) otherButton: toNSStr(p_dialog->cancel) informativeTextWithFormat: toNSStr(p_dialog->message)];
+    o_alert = [NSAlert alertWithMessageText: toNSStr(p_dialog->title) defaultButton: toNSStr(p_dialog->yes) alternateButton: toNSStr(p_dialog->no) otherButton: toNSStr(p_dialog->cancel) informativeTextWithFormat:@"%@", toNSStr(p_dialog->message)];
     [o_alert setAlertStyle: NSInformationalAlertStyle];
     i_returnValue = [o_alert runModal];
 



More information about the vlc-commits mailing list