[vlc-commits] qt: discard bookmark byte offset

Rémi Denis-Courmont git at videolan.org
Tue Aug 27 21:40:42 CEST 2013


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Aug 27 21:56:38 2013 +0300| [c58eadf3d60764a4d2ca0babf5deb0b747acea35] | committer: Rémi Denis-Courmont

qt: discard bookmark byte offset

This is useless given that the time offset is set and the input core
ignores the byte offset when the time offset is set. I think the column
should probably be removed completely.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c58eadf3d60764a4d2ca0babf5deb0b747acea35
---

 modules/gui/qt4/dialogs/bookmarks.cpp |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/gui/qt4/dialogs/bookmarks.cpp b/modules/gui/qt4/dialogs/bookmarks.cpp
index 4867c88..18558db 100644
--- a/modules/gui/qt4/dialogs/bookmarks.cpp
+++ b/modules/gui/qt4/dialogs/bookmarks.cpp
@@ -141,7 +141,7 @@ void BookmarksDialog::update()
         // List with the differents elements of the row
         QStringList row;
         row << QString( qfu( pp_bookmarks[i]->psz_name ) );
-        row << QString::number( pp_bookmarks[i]->i_byte_offset );
+        row << qfu("-");
         int total = pp_bookmarks[i]->i_time_offset/ 1000000;
         int hour = total / (60*60);
         int min = (total - hour*60*60) / 60;
@@ -240,8 +240,6 @@ void BookmarksDialog::edit( QTreeWidgetItem *item, int column )
         free( p_seekpoint->psz_name );
         p_seekpoint->psz_name = strdup( qtu( item->text( column ) ) );
     }
-    else if( column == 1 )
-        p_seekpoint->i_byte_offset = atoi( qtu( item->text( column ) ) );
     else if( column == 2 )
     {
         fields = item->text( column ).split( ":", QString::SkipEmptyParts );



More information about the vlc-commits mailing list