[vlc-commits] audioscrobbler: fix memory leak (cid #1048937 and others)

Rémi Duraffort git at videolan.org
Mon Dec 2 08:53:13 CET 2013


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Mon Dec  2 08:52:27 2013 +0100| [884edd40de00a5f1f800946d2c4e88c19c3ae2ff] | committer: Rémi Duraffort

audioscrobbler: fix memory leak (cid #1048937 and others)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=884edd40de00a5f1f800946d2c4e88c19c3ae2ff
---

 modules/misc/audioscrobbler.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/misc/audioscrobbler.c b/modules/misc/audioscrobbler.c
index f6ff2d3..d93972b 100644
--- a/modules/misc/audioscrobbler.c
+++ b/modules/misc/audioscrobbler.c
@@ -542,6 +542,7 @@ static int Handshake(intf_thread_t *p_this)
     psz_scrobbler_url = var_InheritString(p_this, "scrobbler-url");
     if (!psz_scrobbler_url)
     {
+        free(psz_auth_token);
         free(psz_username);
         return VLC_ENOMEM;
     }
@@ -550,6 +551,7 @@ static int Handshake(intf_thread_t *p_this)
     "http://%s/?hs=true&p=1.2&c="CLIENT_NAME"&v="CLIENT_VERSION"&u=%s&t=%s&a=%s"
     , psz_scrobbler_url, psz_username, psz_timestamp, psz_auth_token);
 
+    free(psz_auth_token);
     free(psz_scrobbler_url);
     free(psz_username);
     if (i_ret == -1)



More information about the vlc-commits mailing list